diff --git a/dialects/dialect.go b/dialects/dialect.go index b02ec4ae..52655e6b 100644 --- a/dialects/dialect.go +++ b/dialects/dialect.go @@ -217,7 +217,7 @@ func regDrvsNDialects() bool { "sqlite3": {"sqlite3", func() Driver { return &sqlite3Driver{} }, func() Dialect { return &sqlite3{} }}, "sqlite": {"sqlite3", func() Driver { return &sqlite3Driver{} }, func() Dialect { return &sqlite3{} }}, "oci8": {"oracle", func() Driver { return &oci8Driver{} }, func() Dialect { return &oracle{} }}, - "goracle": {"oracle", func() Driver { return &goracleDriver{} }, func() Dialect { return &oracle{} }}, + "godror": {"oracle", func() Driver { return &godrorDriver{} }, func() Dialect { return &oracle{} }}, } for driverName, v := range providedDrvsNDialects { diff --git a/dialects/oracle.go b/dialects/oracle.go index 91eed251..72bbe54d 100644 --- a/dialects/oracle.go +++ b/dialects/oracle.go @@ -802,10 +802,10 @@ func (db *oracle) Filters() []Filter { } } -type goracleDriver struct { +type godrorDriver struct { } -func (cfg *goracleDriver) Parse(driverName, dataSourceName string) (*URI, error) { +func (cfg *godrorDriver) Parse(driverName, dataSourceName string) (*URI, error) { db := &URI{DBType: schemas.ORACLE} dsnPattern := regexp.MustCompile( `^(?:(?P.*?)(?::(?P.*))?@)?` + // [user[:password]@] diff --git a/integrations/session_find_test.go b/integrations/session_find_test.go index becb1494..cd623417 100644 --- a/integrations/session_find_test.go +++ b/integrations/session_find_test.go @@ -84,6 +84,9 @@ func TestFind(t *testing.T) { err := testEngine.Find(&users) assert.NoError(t, err) + err = testEngine.Limit(10, 0).Find(&users) + assert.NoError(t, err) + users2 := make([]Userinfo, 0) var tbName = testEngine.Quote(testEngine.TableName(new(Userinfo), true)) err = testEngine.SQL("select * from " + tbName).Find(&users2)