From 147328f6298a87593f1edf341ff07a23d785b673 Mon Sep 17 00:00:00 2001 From: andreasgerstmayr Date: Mon, 12 Jul 2021 23:51:50 +0800 Subject: [PATCH] fix possible null dereference in internal/statements/query.go (#1988) Make sure that pLimitN is not `nil` before dereferencing the pointer. Co-authored-by: Andreas Gerstmayr Reviewed-on: https://gitea.com/xorm/xorm/pulls/1988 Co-authored-by: andreasgerstmayr Co-committed-by: andreasgerstmayr --- internal/statements/query.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/statements/query.go b/internal/statements/query.go index a972a8e0..69f48e73 100644 --- a/internal/statements/query.go +++ b/internal/statements/query.go @@ -314,7 +314,7 @@ func (statement *Statement) genSelectSQL(columnStr string, needLimit, needOrderB fmt.Fprint(&buf, " LIMIT ", *pLimitN) } } else if dialect.URI().DBType == schemas.ORACLE { - if statement.Start != 0 || pLimitN != nil { + if statement.Start != 0 && pLimitN != nil { oldString := buf.String() buf.Reset() rawColStr := columnStr