From 1c81f5257604dcc768e3e33480ad358acbb8f14f Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Fri, 14 Mar 2014 15:05:58 +0800 Subject: [PATCH] update tests --- base_test.go | 30 +++++++++++++++++++----------- xorm/reverse.go | 13 +++++++------ 2 files changed, 26 insertions(+), 17 deletions(-) diff --git a/base_test.go b/base_test.go index 91da58c6..92eb6290 100644 --- a/base_test.go +++ b/base_test.go @@ -331,37 +331,45 @@ func update(engine *Engine, t *testing.T) { panic(err) } - cnt, err = engine.Insert(&Article{0, "1", "2", "3", "4", "5", 2}) + defer func() { + err = engine.DropTables(&Article{}) + if err != nil { + t.Error(err) + panic(err) + } + }() + + a := &Article{0, "1", "2", "3", "4", "5", 2} + cnt, err = engine.Insert(a) if err != nil { t.Error(err) panic(err) } if cnt != 1 { - err = errors.New("insert not returned 1") + err = errors.New(fmt.Sprintf("insert not returned 1 but %d", cnt)) t.Error(err) panic(err) - return } - cnt, err = engine.Id(1).Update(&Article{Name: "6"}) + if a.Id == 0 { + err = errors.New("insert returned id is 0") + t.Error(err) + panic(err) + } + + cnt, err = engine.Id(a.Id).Update(&Article{Name: "6"}) if err != nil { t.Error(err) panic(err) } if cnt != 1 { - err = errors.New("update not returned 1") + err = errors.New(fmt.Sprintf("insert not returned 1 but %d", cnt)) t.Error(err) panic(err) return } - - err = engine.DropTables(&Article{}) - if err != nil { - t.Error(err) - panic(err) - } } func updateSameMapper(engine *Engine, t *testing.T) { diff --git a/xorm/reverse.go b/xorm/reverse.go index 7eab1980..e0a0f3b3 100644 --- a/xorm/reverse.go +++ b/xorm/reverse.go @@ -3,12 +3,6 @@ package main import ( "bytes" "fmt" - _ "github.com/bylevel/pq" - "github.com/dvirsky/go-pylog/logging" - _ "github.com/go-sql-driver/mysql" - "github.com/lunny/xorm" - _ "github.com/mattn/go-sqlite3" - _ "github.com/ziutek/mymysql/godrv" "io/ioutil" "os" "path" @@ -16,6 +10,13 @@ import ( "strconv" "strings" //[SWH|+] "text/template" + + "github.com/dvirsky/go-pylog/logging" + _ "github.com/go-sql-driver/mysql" + _ "github.com/lib/pq" + "github.com/lunny/xorm" + _ "github.com/mattn/go-sqlite3" + _ "github.com/ziutek/mymysql/godrv" ) var CmdReverse = &Command{