From 1fc32902fd811cd573fbba7b21786cc04bc9da1e Mon Sep 17 00:00:00 2001
From: Lunny Xiao <xiaolunwen@gmail.com>
Date: Fri, 27 Dec 2019 13:18:14 +0800
Subject: [PATCH] Improve tests

---
 session_insert_test.go | 29 +++++++++++++++++++++++++----
 session_update_test.go | 24 +++++++++++++++++++++++-
 2 files changed, 48 insertions(+), 5 deletions(-)

diff --git a/session_insert_test.go b/session_insert_test.go
index da222e86..657d2b12 100644
--- a/session_insert_test.go
+++ b/session_insert_test.go
@@ -942,17 +942,28 @@ func TestInsertExpr2(t *testing.T) {
 
 	assertSync(t, new(InsertExprsRelease))
 
+	var ie = InsertExprsRelease{
+		RepoId: 1,
+		IsTag:  true,
+	}
 	inserted, err := testEngine.
 		SetExpr("is_draft", true).
 		SetExpr("num_commits", 0).
 		SetExpr("sha1", "").
-		Insert(&InsertExprsRelease{
-			RepoId: 1,
-			IsTag:  true,
-		})
+		Insert(&ie)
 	assert.NoError(t, err)
 	assert.EqualValues(t, 1, inserted)
 
+	var ie2 InsertExprsRelease
+	has, err := testEngine.ID(ie.Id).Get(&ie2)
+	assert.NoError(t, err)
+	assert.True(t, has)
+	assert.EqualValues(t, true, ie2.IsDraft)
+	assert.EqualValues(t, "", ie2.Sha1)
+	assert.EqualValues(t, 0, ie2.NumCommits)
+	assert.EqualValues(t, 1, ie2.RepoId)
+	assert.EqualValues(t, true, ie2.IsTag)
+
 	inserted, err = testEngine.Table(new(InsertExprsRelease)).
 		SetExpr("is_draft", true).
 		SetExpr("num_commits", 0).
@@ -963,6 +974,16 @@ func TestInsertExpr2(t *testing.T) {
 		})
 	assert.NoError(t, err)
 	assert.EqualValues(t, 1, inserted)
+
+	var ie3 InsertExprsRelease
+	has, err = testEngine.ID(ie.Id + 1).Get(&ie3)
+	assert.NoError(t, err)
+	assert.True(t, has)
+	assert.EqualValues(t, true, ie3.IsDraft)
+	assert.EqualValues(t, "", ie3.Sha1)
+	assert.EqualValues(t, 0, ie3.NumCommits)
+	assert.EqualValues(t, 1, ie3.RepoId)
+	assert.EqualValues(t, true, ie3.IsTag)
 }
 
 type NightlyRate struct {
diff --git a/session_update_test.go b/session_update_test.go
index 8f2f891e..d0ecef33 100644
--- a/session_update_test.go
+++ b/session_update_test.go
@@ -1374,11 +1374,33 @@ func TestUpdateExprs2(t *testing.T) {
 
 	assertSync(t, new(UpdateExprsRelease))
 
-	_, err := testEngine.
+	var uer = UpdateExprsRelease{
+		RepoId:     1,
+		IsTag:      false,
+		IsDraft:    false,
+		NumCommits: 1,
+		Sha1:       "sha1",
+	}
+	inserted, err := testEngine.Insert(&uer)
+	assert.NoError(t, err)
+	assert.EqualValues(t, 1, inserted)
+
+	updated, err := testEngine.
 		Where("repo_id = ? AND is_tag = ?", 1, false).
 		SetExpr("is_draft", true).
 		SetExpr("num_commits", 0).
 		SetExpr("sha1", "").
 		Update(new(UpdateExprsRelease))
 	assert.NoError(t, err)
+	assert.EqualValues(t, 1, updated)
+
+	var uer2 UpdateExprsRelease
+	has, err := testEngine.ID(uer.Id).Get(&uer2)
+	assert.NoError(t, err)
+	assert.True(t, has)
+	assert.EqualValues(t, 1, uer2.RepoId)
+	assert.EqualValues(t, false, uer2.IsTag)
+	assert.EqualValues(t, true, uer2.IsDraft)
+	assert.EqualValues(t, 0, uer2.NumCommits)
+	assert.EqualValues(t, "", uer2.Sha1)
 }