From 2ad8cfb1e8b0e786265728113c5bb0d7d736985a Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Wed, 4 Aug 2021 23:30:23 +0800 Subject: [PATCH] Fix bug --- dialects/dialect.go | 10 ++++++++-- integrations/session_schema_test.go | 5 +++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/dialects/dialect.go b/dialects/dialect.go index 396727ce..d62b00a6 100644 --- a/dialects/dialect.go +++ b/dialects/dialect.go @@ -335,8 +335,14 @@ func ColumnString(dialect Dialect, col *schemas.Column, includePrimaryKey bool) if _, err := bd.WriteString(" DEFAULT "); err != nil { return "", err } - if _, err := bd.WriteString(col.Default); err != nil { - return "", err + if col.Default == "" { + if _, err := bd.WriteString("''"); err != nil { + return "", err + } + } else { + if _, err := bd.WriteString(col.Default); err != nil { + return "", err + } } } diff --git a/integrations/session_schema_test.go b/integrations/session_schema_test.go index 9cbebcbf..98ad9657 100644 --- a/integrations/session_schema_test.go +++ b/integrations/session_schema_test.go @@ -526,8 +526,9 @@ func TestModifyColum(t *testing.T) { SQLType: schemas.SQLType{ Name: "VARCHAR", }, - Length: 16, - Nullable: false, + Length: 16, + Nullable: false, + DefaultIsEmpty: true, }) _, err := testEngine.Exec(alterSQL) assert.NoError(t, err)