diff --git a/session_query_test.go b/session_query_test.go index 5ce89a4a..fe806d02 100644 --- a/session_query_test.go +++ b/session_query_test.go @@ -334,3 +334,47 @@ func TestQueryWithBuilder(t *testing.T) { assert.NoError(t, err) assertResult(t, results) } + +func TestJoinWithSubQuery(t *testing.T) { + assert.NoError(t, prepareEngine()) + + type JoinWithSubQuery1 struct { + Id int64 `xorm:"autoincr pk"` + Msg string `xorm:"varchar(255)"` + DepartId int64 + Money float32 + } + + type JoinWithSubQueryDepart struct { + Id int64 `xorm:"autoincr pk"` + Name string + } + + testEngine.ShowSQL(true) + + assert.NoError(t, testEngine.Sync2(new(JoinWithSubQuery1), new(JoinWithSubQueryDepart))) + + var depart = JoinWithSubQueryDepart{ + Name: "depart1", + } + cnt, err := testEngine.Insert(&depart) + assert.NoError(t, err) + assert.EqualValues(t, 1, cnt) + + var q = JoinWithSubQuery1{ + Msg: "message", + DepartId: depart.Id, + Money: 3000, + } + + cnt, err = testEngine.Insert(&q) + assert.NoError(t, err) + assert.EqualValues(t, 1, cnt) + + var querys []JoinWithSubQuery1 + err = testEngine.Join("INNER", builder.Select("id").From("join_with_sub_query_depart"), + "join_with_sub_query_depart.id = join_with_sub_query1.depart_id").Find(&querys) + assert.NoError(t, err) + assert.EqualValues(t, 1, len(querys)) + assert.EqualValues(t, q, querys[0]) +} diff --git a/statement.go b/statement.go index 00a3bff9..7a59d9f3 100644 --- a/statement.go +++ b/statement.go @@ -758,21 +758,21 @@ func (statement *Statement) Join(joinOP string, tablename interface{}, condition } switch tp := tablename.(type) { - case *builder.Builder: - subSQL, subQueryArgs, err := tp.ToSQL() - if err != nil { - statement.lastError = err - return statement - } - fmt.Fprintf(&buf, "(%s) ON %v", subSQL, condition) - statement.joinArgs = append(statement.joinArgs, subQueryArgs...) case builder.Builder: subSQL, subQueryArgs, err := tp.ToSQL() if err != nil { statement.lastError = err return statement } - fmt.Fprintf(&buf, "(%s) ON %v", subSQL, condition) + fmt.Fprintf(&buf, "(%s) %s ON %v", subSQL, tp.TableName(), condition) + statement.joinArgs = append(statement.joinArgs, subQueryArgs...) + case *builder.Builder: + subSQL, subQueryArgs, err := tp.ToSQL() + if err != nil { + statement.lastError = err + return statement + } + fmt.Fprintf(&buf, "(%s) %s ON %v", subSQL, tp.TableName(), condition) statement.joinArgs = append(statement.joinArgs, subQueryArgs...) default: tbName := statement.Engine.TableName(tablename, true)