From 6132eea08c596bdcfb2d7aac7209d9cf61776ebc Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Tue, 24 Mar 2020 02:51:37 +0000 Subject: [PATCH] Fix dump test (#1625) Fix dump test Reviewed-on: https://gitea.com/xorm/xorm/pulls/1625 --- engine_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/engine_test.go b/engine_test.go index d6da5f33..b691d909 100644 --- a/engine_test.go +++ b/engine_test.go @@ -85,7 +85,7 @@ func TestDump(t *testing.T) { {Name: "5'\n"}, }) - fp := testEngine.Dialect().URI().DBName + ".sql" + fp := fmt.Sprintf("%v.sql", testEngine.Dialect().URI().DBType) os.Remove(fp) assert.NoError(t, testEngine.DumpAllToFile(fp)) @@ -99,8 +99,9 @@ func TestDump(t *testing.T) { assert.NoError(t, sess.Commit()) for _, tp := range []schemas.DBType{schemas.SQLITE, schemas.MYSQL, schemas.POSTGRES, schemas.MSSQL} { - t.Run(fmt.Sprintf("dump_%v", tp), func(t *testing.T) { - assert.NoError(t, testEngine.DumpAllToFile(fp, tp)) + name := fmt.Sprintf("dump_%v.sql", tp) + t.Run(name, func(t *testing.T) { + assert.NoError(t, testEngine.DumpAllToFile(name, tp)) }) } }