From 70e3838441eb8f2d7773b508f1cd056603307f40 Mon Sep 17 00:00:00 2001 From: leiwingqueen Date: Fri, 1 Mar 2024 18:35:35 +0800 Subject: [PATCH] fix asc and desc clause --- internal/statements/order_by.go | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/internal/statements/order_by.go b/internal/statements/order_by.go index 61742ff9..49ba1fc5 100644 --- a/internal/statements/order_by.go +++ b/internal/statements/order_by.go @@ -118,11 +118,14 @@ func (statement *Statement) Desc(colNames ...string) *Statement { } for _, colName := range colNames { ob := orderBy{colName, nil, "DESC"} - statement.orderBy = append(statement.orderBy, ob) - if _, err := ob.CheckValid(); err != nil { + notNil, err := ob.CheckValid() + if err != nil { statement.LastError = err return statement } + if notNil { + statement.orderBy = append(statement.orderBy, ob) + } } return statement } @@ -135,11 +138,14 @@ func (statement *Statement) Asc(colNames ...string) *Statement { } for _, colName := range colNames { ob := orderBy{colName, nil, "ASC"} - statement.orderBy = append(statement.orderBy, ob) - if _, err := ob.CheckValid(); err != nil { + notNil, err := ob.CheckValid() + if err != nil { statement.LastError = err return statement } + if notNil { + statement.orderBy = append(statement.orderBy, ob) + } } return statement }