HiPoweredDev
/
xorm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix potential data race in Column.fieldPath (#21)

This commit is contained in:
Kenichi Yonekawa 2017-02-07 00:24:21 +09:00 committed by Lunny Xiao
parent 2fbe2c76c6
commit 7daacb215e
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
column.go
View File

@ -32,7 +32,6 @@ type Column struct {
IsDeleted bool IsDeleted bool
IsCascade bool IsCascade bool
IsVersion bool IsVersion bool
fieldPath []string
DefaultIsEmpty bool DefaultIsEmpty bool
EnumOptions map[string]int EnumOptions map[string]int
SetOptions map[string]int SetOptions map[string]int
@ -59,7 +58,6 @@ func NewColumn(name, fieldName string, sqlType SQLType, len1, len2 int, nullable
IsDeleted: false, IsDeleted: false,
IsCascade: false, IsCascade: false,
IsVersion: false, IsVersion: false,
fieldPath: nil,
DefaultIsEmpty: false, DefaultIsEmpty: false,
EnumOptions: make(map[string]int), EnumOptions: make(map[string]int),
} }
@ -121,12 +119,10 @@ func (col *Column) ValueOf(bean interface{}) (*reflect.Value, error) {
func (col *Column) ValueOfV(dataStruct *reflect.Value) (*reflect.Value, error) { func (col *Column) ValueOfV(dataStruct *reflect.Value) (*reflect.Value, error) {
var fieldValue reflect.Value var fieldValue reflect.Value
if col.fieldPath == nil { fieldPath := strings.Split(col.FieldName, ".")
col.fieldPath = strings.Split(col.FieldName, ".")
}
if dataStruct.Type().Kind() == reflect.Map { if dataStruct.Type().Kind() == reflect.Map {
keyValue := reflect.ValueOf(col.fieldPath[len(col.fieldPath)-1]) keyValue := reflect.ValueOf(fieldPath[len(fieldPath)-1])
fieldValue = dataStruct.MapIndex(keyValue) fieldValue = dataStruct.MapIndex(keyValue)
return &fieldValue, nil return &fieldValue, nil
} else if dataStruct.Type().Kind() == reflect.Interface { } else if dataStruct.Type().Kind() == reflect.Interface {
@ -134,19 +130,19 @@ func (col *Column) ValueOfV(dataStruct *reflect.Value) (*reflect.Value, error) {
dataStruct = &structValue dataStruct = &structValue
} }
level := len(col.fieldPath) level := len(fieldPath)
fieldValue = dataStruct.FieldByName(col.fieldPath[0]) fieldValue = dataStruct.FieldByName(fieldPath[0])
for i := 0; i < level-1; i++ { for i := 0; i < level-1; i++ {
if !fieldValue.IsValid() { if !fieldValue.IsValid() {
break break
} }
if fieldValue.Kind() == reflect.Struct { if fieldValue.Kind() == reflect.Struct {
fieldValue = fieldValue.FieldByName(col.fieldPath[i+1]) fieldValue = fieldValue.FieldByName(fieldPath[i+1])
} else if fieldValue.Kind() == reflect.Ptr { } else if fieldValue.Kind() == reflect.Ptr {
if fieldValue.IsNil() { if fieldValue.IsNil() {
fieldValue.Set(reflect.New(fieldValue.Type().Elem())) fieldValue.Set(reflect.New(fieldValue.Type().Elem()))
} }
fieldValue = fieldValue.Elem().FieldByName(col.fieldPath[i+1]) fieldValue = fieldValue.Elem().FieldByName(fieldPath[i+1])
} else { } else {
return nil, fmt.Errorf("field %v is not valid", col.FieldName) return nil, fmt.Errorf("field %v is not valid", col.FieldName)
} }