HiPoweredDev
/
xorm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drop duplicated feature

This commit is contained in:
Lunny Xiao 2021-08-04 22:04:49 +08:00
parent dc980514bd
commit 7fc2459df9
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dialects/dialect.go
View File

@ -45,7 +45,6 @@ const (
type DialectFeatures struct { type DialectFeatures struct {
AutoincrMode int // 0 autoincrement column, 1 sequence AutoincrMode int // 0 autoincrement column, 1 sequence
SupportSequence bool
} }
// Dialect represents a kind of database // Dialect represents a kind of database

2
engine.go
View File

@ -513,7 +513,7 @@ func (engine *Engine) dumpTables(ctx context.Context, tables []*schemas.Table, w
return err return err
} }
if dstTable.AutoIncrement != "" && dstDialect.Features().SupportSequence { if dstTable.AutoIncrement != "" && dstDialect.Features().AutoincrMode == dialects.SequenceAutoincrMode {
sqlstr, err = dstDialect.CreateSequenceSQL(ctx, engine.db, utils.SeqName(dstTableName)) sqlstr, err = dstDialect.CreateSequenceSQL(ctx, engine.db, utils.SeqName(dstTableName))
if err != nil { if err != nil {
return err return err

5
session_schema.go
View File

@ -13,6 +13,7 @@ import (
"os" "os"
"strings" "strings"
"xorm.io/xorm/dialects"
"xorm.io/xorm/internal/utils" "xorm.io/xorm/internal/utils"
"xorm.io/xorm/schemas" "xorm.io/xorm/schemas"
) )
@ -53,7 +54,7 @@ func (session *Session) createTable(bean interface{}) error {
return err return err
} }
if refTable.AutoIncrement != "" && session.engine.dialect.Features().SupportSequence { if refTable.AutoIncrement != "" && session.engine.dialect.Features().AutoincrMode == dialects.SequenceAutoincrMode {
sqlStr, err = session.engine.dialect.CreateSequenceSQL(context.Background(), session.engine.db, utils.SeqName(tableName)) sqlStr, err = session.engine.dialect.CreateSequenceSQL(context.Background(), session.engine.db, utils.SeqName(tableName))
if err != nil { if err != nil {
return err return err
@ -164,7 +165,7 @@ func (session *Session) dropTable(beanOrTableName interface{}) error {
return err return err
} }
if !session.engine.dialect.Features().SupportSequence { if session.engine.dialect.Features().AutoincrMode == dialects.IncrAutoincrMode {
return nil return nil
} }