HiPoweredDev
/
xorm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge 9477d3719c into f16ce722ec

This commit is contained in:
Can 2018-06-28 09:29:04 +00:00 committed by GitHub
parent f16ce722ec 9477d3719c
commit 907f8e0fd1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 29 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
statement.go
View File

@ -1067,9 +1067,10 @@ func (statement *Statement) genSelectSQL(columnStr, condSQL string, needLimit, n
}
if dialect.DBType() == core.MSSQL {
if statement.LimitN > 0 {
// !cantasci! this condition is not necesarry for now.
/*if statement.LimitN > 0 {
top = fmt.Sprintf(" TOP %d", statement.LimitN)
}
}*/
if statement.Start > 0 {
var column string
if len(statement.RefTable.PKColumns()) == 0 {
@ -1109,7 +1110,7 @@ func (statement *Statement) genSelectSQL(columnStr, condSQL string, needLimit, n
// !nashtsai! REVIEW Sprintf is considered slowest mean of string concatnation, better to work with builder pattern
a = fmt.Sprintf("SELECT %v%v%v%v%v", distinct, top, columnStr, fromStr, whereStr)
if len(mssqlCondi) > 0 {
if statement.Start == 0 && len(mssqlCondi) > 0 {
if len(whereStr) > 0 {
a += " AND " + mssqlCondi
} else {
@ -1138,6 +1139,12 @@ func (statement *Statement) genSelectSQL(columnStr, condSQL string, needLimit, n
a = fmt.Sprintf("SELECT %v FROM (SELECT %v,ROWNUM RN FROM (%v) at WHERE ROWNUM <= %d) aat WHERE RN > %d", columnStr, columnStr, a, statement.Start+statement.LimitN, statement.Start)
}
}
} else if dialect.DBType() == core.MSSQL {
if statement.Start != 0 || statement.LimitN != 0 {
// !cantasci! use cte for related query when limit and offset values are set, then return filtered result by [start, start+limitN]
offsetColumn := statement.getPrimaryColumnForOffset()
a = fmt.Sprintf("WITH SQLPaging AS (SELECT TOP(%d) ROW_NUMBER() OVER (ORDER BY %v ASC) AS RN, %v FROM(%v) AS TEMP_TABLE_NAME) SELECT %v FROM SQLPaging WITH(NOLOCK) WHERE RN > %d AND RN < %d", statement.LimitN+statement.Start, offsetColumn, columnStr, a, columnStr, statement.Start, statement.Start+statement.LimitN+1)
}
}
if statement.IsForUpdate {
a = dialect.ForUpdateSql(a)
@ -1146,6 +1153,24 @@ func (statement *Statement) genSelectSQL(columnStr, condSQL string, needLimit, n
return
}
func (statement *Statement) getPrimaryColumnForOffset() string {
var column string
if len(statement.RefTable.PKColumns()) == 0 {
for _, index := range statement.RefTable.Indexes {
if len(index.Cols) == 1 {
column = index.Cols[0]
break
}
}
if len(column) == 0 {
column = statement.RefTable.ColumnsSeq()[0]
}
} else {
column = statement.RefTable.PKColumns()[0].Name
}
return column
}
func (statement *Statement) processIDParam() error {
if statement.idParam == nil || statement.RefTable == nil {
return nil