From 4f70aace97959b7d9c3937bf3ddb5f4b27a99370 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=95=86=E8=AE=AF=E5=9C=A8=E7=BA=BF?= Date: Sun, 11 May 2014 18:39:07 +0800 Subject: [PATCH 1/4] fix bug:Iterate func missing "... IN (...)" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: 商讯在线 --- statement.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/statement.go b/statement.go index 417d5b9d..4a73dd54 100644 --- a/statement.go +++ b/statement.go @@ -960,7 +960,7 @@ func (statement *Statement) genGetSql(bean interface{}) (string, []interface{}) if columnStr == "" { columnStr = statement.genColumnStr() } - + statement.attachInSql() //[SWH|+] return statement.genSelectSql(columnStr), append(statement.Params, statement.BeanArgs...) } From 3a6df0e1bdd44d4b3144bb83ebd2e898c0f289d4 Mon Sep 17 00:00:00 2001 From: Nash Tsai Date: Mon, 12 May 2014 11:25:36 +0800 Subject: [PATCH 2/4] tidy up comments --- statement.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/statement.go b/statement.go index 4a73dd54..e0cb0b70 100644 --- a/statement.go +++ b/statement.go @@ -960,7 +960,8 @@ func (statement *Statement) genGetSql(bean interface{}) (string, []interface{}) if columnStr == "" { columnStr = statement.genColumnStr() } - statement.attachInSql() //[SWH|+] + + statement.attachInSql() // !admpub! fix bug:Iterate func missing "... IN (...)" return statement.genSelectSql(columnStr), append(statement.Params, statement.BeanArgs...) } From ca802489d8c70199f314d6d6cd4bc57aeefff269 Mon Sep 17 00:00:00 2001 From: Nash Tsai Date: Mon, 12 May 2014 11:26:48 +0800 Subject: [PATCH 3/4] update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4b806704..8d9aa0f6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,7 +17,7 @@ proposed functionality. ### Bug reports We appreciate any bug reports, but especially ones with self-contained -(doesn't depend on code outside of pq), minimal (can't be simplified +(doesn't depend on code outside of xorm), minimal (can't be simplified further) test cases. It's especially helpful if you can submit a pull request with just the failing test case (you'll probably want to pattern it after the tests in From 8a6a87408b81bc82fca57c4840ed0f787e51bab6 Mon Sep 17 00:00:00 2001 From: Nash Tsai Date: Mon, 12 May 2014 11:29:29 +0800 Subject: [PATCH 4/4] add code signing tips to CONTRIBUTING.md --- CONTRIBUTING.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8d9aa0f6..90f630ea 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,6 +9,15 @@ conventions when submitting patches. * [fork a repo](https://help.github.com/articles/fork-a-repo) * [creating a pull request ](https://help.github.com/articles/creating-a-pull-request) +### Sign your codes with comments +``` +// !! your comments + +e.g., + +// !lunny! this is comments made by lunny +``` + ### Patch review Help review existing open [pull requests](https://help.github.com/articles/using-pull-requests) by commenting on the code or