HiPoweredDev
/
xorm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Code refactoring

This commit is contained in:
marshalys 2018-10-26 14:03:43 +08:00
parent 98de0142e8
commit a7e2cb5681
3 changed files with 9 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
session.go
View File

@ -846,19 +846,11 @@ func (session *Session) Unscoped() *Session {
return session
}
func (session *Session) freshVersionFieldValue(fieldValue *reflect.Value, isInsert bool) {
func (session *Session) incrVersionFieldValue(fieldValue *reflect.Value) {
switch fieldValue.Kind() {
case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
if isInsert {
fieldValue.SetInt(1)
} else {
fieldValue.SetInt(fieldValue.Int() + 1)
}
case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
if isInsert {
fieldValue.SetUint(1)
} else {
case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:
fieldValue.SetUint(fieldValue.Uint() + 1)
}
}
}

6
session_insert.go
View File

@ -397,7 +397,7 @@ func (session *Session) innerInsert(bean interface{}) (int64, error) {
if err != nil {
session.engine.logger.Error(err)
} else if verValue.IsValid() && verValue.CanSet() {
session.freshVersionFieldValue(verValue, true)
session.incrVersionFieldValue(verValue)
}
}
@ -440,7 +440,7 @@ func (session *Session) innerInsert(bean interface{}) (int64, error) {
if err != nil {
session.engine.logger.Error(err)
} else if verValue.IsValid() && verValue.CanSet() {
session.freshVersionFieldValue(verValue, true)
session.incrVersionFieldValue(verValue)
}
}
@ -481,7 +481,7 @@ func (session *Session) innerInsert(bean interface{}) (int64, error) {
if err != nil {
session.engine.logger.Error(err)
} else if verValue.IsValid() && verValue.CanSet() {
session.freshVersionFieldValue(verValue, true)
session.incrVersionFieldValue(verValue)
}
}

4
session_update.go
View File

@ -116,7 +116,7 @@ func (session *Session) cacheUpdate(table *core.Table, tableName, sqlStr string,
} else {
session.engine.logger.Debug("[cacheUpdate] set bean field", bean, colName, fieldValue.Interface())
if col.IsVersion && session.statement.checkVersion {
session.freshVersionFieldValue(fieldValue, false)
session.incrVersionFieldValue(fieldValue)
} else {
fieldValue.Set(reflect.ValueOf(args[idx]))
}
@ -357,7 +357,7 @@ func (session *Session) Update(bean interface{}, condiBean ...interface{}) (int6
return 0, err
} else if doIncVer {
if verValue != nil && verValue.IsValid() && verValue.CanSet() {
session.freshVersionFieldValue(verValue, false)
session.incrVersionFieldValue(verValue)
}
}