From a9e2ecbf44516f5bb82743776cec8d7b8dcf9ad4 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Thu, 20 Feb 2020 03:41:19 +0000 Subject: [PATCH] Fix wrong warning log on autoincrement column when sync table (#1525) improve doc Fix wrong warning log on autoincrement column when sync table Reviewed-on: https://gitea.com/xorm/xorm/pulls/1525 --- session_schema.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/session_schema.go b/session_schema.go index 5e576c29..d4c71374 100644 --- a/session_schema.go +++ b/session_schema.go @@ -346,10 +346,12 @@ func (session *Session) Sync2(beans ...interface{}) error { } if col.Default != oriCol.Default { - if (col.SQLType.Name == core.Bool || col.SQLType.Name == core.Boolean) && + switch { + case col.IsAutoIncrement: // For autoincrement column, don't check default + case (col.SQLType.Name == core.Bool || col.SQLType.Name == core.Boolean) && ((strings.EqualFold(col.Default, "true") && oriCol.Default == "1") || - (strings.EqualFold(col.Default, "false") && oriCol.Default == "0")) { - } else { + (strings.EqualFold(col.Default, "false") && oriCol.Default == "0")): + default: engine.logger.Warnf("Table %s Column %s db default is %s, struct default is %s", tbName, col.Name, oriCol.Default, col.Default) }