Remove quotestr totally (#1366)

* remove QuoteStr() totally

* update xorm.core -> v0.7.0

* update dialect Quote

dialect_mssql.go

@@ -286,10 +286,6 @@ func (db *mssql) Quote(name string) string {
 	return "\"" + name + "\""
 }
 
-func (db *mssql) QuoteStr() string {
-	return "\""
-}
-
 func (db *mssql) SupportEngine() bool {
 	return false
 }

dialect_mysql.go

@@ -278,10 +278,6 @@ func (db *mysql) Quote(name string) string {
 	return "`" + name + "`"
 }
 
-func (db *mysql) QuoteStr() string {
-	return "`"
-}
-
 func (db *mysql) SupportEngine() bool {
 	return true
 }
@@ -559,8 +555,6 @@ func (db *mysql) CreateTableSql(table *core.Table, tableName, storeEngine, chars
 		sql += " DEFAULT CHARSET " + charset
 	}
 
-	
-
 	if db.rowFormat != "" {
 		sql += " ROW_FORMAT=" + db.rowFormat
 	}

dialect_oracle.go

@@ -552,11 +552,7 @@ func (db *oracle) IsReserved(name string) bool {
 }
 
 func (db *oracle) Quote(name string) string {
-	return "\"" + name + "\""
-}
-
-func (db *oracle) QuoteStr() string {
-	return "\""
+	return "[" + name + "]"
 }
 
 func (db *oracle) SupportEngine() bool {

dialect_postgres.go

@@ -863,10 +863,6 @@ func (db *postgres) Quote(name string) string {
 	return "\"" + name + "\""
 }
 
-func (db *postgres) QuoteStr() string {
-	return "\""
-}
-
 func (db *postgres) AutoIncrStr() string {
 	return ""
 }
@@ -1093,7 +1089,6 @@ func (db *postgres) GetTables() ([]*core.Table, error) {
 	return tables, nil
 }
 
-
 func getIndexColName(indexdef string) []string {
 	var colNames []string
 
@@ -1105,7 +1100,6 @@ func getIndexColName(indexdef string) []string {
 	return colNames
 }
 
-
 func (db *postgres) GetIndexes(tableName string) (map[string]*core.Index, error) {
 	args := []interface{}{tableName}
 	s := fmt.Sprintf("SELECT indexname, indexdef FROM pg_indexes WHERE tablename=$1")

dialect_sqlite3.go

@@ -202,10 +202,6 @@ func (db *sqlite3) Quote(name string) string {
 	return "`" + name + "`"
 }
 
-func (db *sqlite3) QuoteStr() string {
-	return "`"
-}
-
 func (db *sqlite3) AutoIncrStr() string {
 	return "AUTOINCREMENT"
 }

go.mod

@@ -15,5 +15,5 @@ require (
 	github.com/stretchr/testify v1.3.0
 	github.com/ziutek/mymysql v1.5.4
 	xorm.io/builder v0.3.5
-	xorm.io/core v0.6.3
+	xorm.io/core v0.7.0
 )