From c8144bd716944a69a7b016c84c0dd92baae061f9 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sat, 12 Jun 2021 13:56:39 +0800 Subject: [PATCH] Fix tidb version parse --- dialects/mysql.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/dialects/mysql.go b/dialects/mysql.go index 670c3928..a169b901 100644 --- a/dialects/mysql.go +++ b/dialects/mysql.go @@ -204,9 +204,9 @@ func (db *mysql) Version(ctx context.Context, queryer core.Queryer) (*schemas.Ve return nil, err } - if strings.HasPrefix(version, "TiDB:") { - // TiDB: 5.7.25-TiDB-v3.0.3 - fields := strings.Split(strings.TrimPrefix(version, "TiDB: "), "-") + fields := strings.Split(version, "-") + if len(fields) == 3 && fields[1] == "TiDB" { + // 5.7.25-TiDB-v3.0.3 return &schemas.Version{ Number: strings.TrimPrefix(fields[2], "v"), Level: fields[0], @@ -214,7 +214,6 @@ func (db *mysql) Version(ctx context.Context, queryer core.Queryer) (*schemas.Ve }, nil } - fields := strings.SplitN(version, "-", 2) var edition string if len(fields) == 2 { edition = fields[1]