From ce380c94309a67f4a6f5104c8f8b609c4459002a Mon Sep 17 00:00:00 2001 From: woodsaj Date: Mon, 14 Mar 2016 22:10:59 +0800 Subject: [PATCH 1/2] quote "."(periods) in column name. fixes #369 Correctly handle columns being passed in the format "table.column" --- engine.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine.go b/engine.go index 18c8d656..e4038d5f 100644 --- a/engine.go +++ b/engine.go @@ -139,7 +139,7 @@ func (engine *Engine) quoteColumn(keyName string) string { keyName = strings.Replace(keyName, "`", "", -1) keyName = strings.Replace(keyName, engine.QuoteStr(), "", -1) - keyName = strings.Replace(keyName, ",", engine.dialect.QuoteStr()+","+engine.dialect.QuoteStr(), -1) + keyName = strings.Replace(keyName, ".", engine.dialect.QuoteStr()+"."+engine.dialect.QuoteStr(), -1) return engine.dialect.QuoteStr() + keyName + engine.dialect.QuoteStr() } From 1080a66c1079e9ab49f0acfaee87e9c98e240360 Mon Sep 17 00:00:00 2001 From: woodsaj Date: Mon, 14 Mar 2016 22:23:45 +0800 Subject: [PATCH 2/2] allow quoteColoumn to handle comma separated column names --- engine.go | 1 + 1 file changed, 1 insertion(+) diff --git a/engine.go b/engine.go index e4038d5f..0f6190f5 100644 --- a/engine.go +++ b/engine.go @@ -139,6 +139,7 @@ func (engine *Engine) quoteColumn(keyName string) string { keyName = strings.Replace(keyName, "`", "", -1) keyName = strings.Replace(keyName, engine.QuoteStr(), "", -1) + keyName = strings.Replace(keyName, ",", engine.dialect.QuoteStr()+","+engine.dialect.QuoteStr(), -1) keyName = strings.Replace(keyName, ".", engine.dialect.QuoteStr()+"."+engine.dialect.QuoteStr(), -1) return engine.dialect.QuoteStr() + keyName + engine.dialect.QuoteStr()