From d7f04c3cecff8d8c9321b2c39940e1992ce9f01a Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sat, 26 Aug 2017 09:38:40 +0800 Subject: [PATCH] fix query string bug when value is nil (#692) --- session_raw.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/session_raw.go b/session_raw.go index 05223c46..6225fed2 100644 --- a/session_raw.go +++ b/session_raw.go @@ -219,16 +219,16 @@ func row2mapStr(rows *core.Rows, fields []string) (resultsMap map[string]string, for ii, key := range fields { rawValue := reflect.Indirect(reflect.ValueOf(scanResultContainers[ii])) - //if row is null then ignore + // if row is null then as empty string if rawValue.Interface() == nil { - //fmt.Println("ignore ...", key, rawValue) + result[key] = "" continue } if data, err := value2String(&rawValue); err == nil { result[key] = data } else { - return nil, err // !nashtsai! REVIEW, should return err or just error log? + return nil, err } } return result, nil