From e59b76cb6cdbe06dccd81f34d59fdbe0031c0f19 Mon Sep 17 00:00:00 2001 From: Nash Tsai Date: Wed, 25 Dec 2013 23:50:37 +0800 Subject: [PATCH] add TODO comments --- session.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/session.go b/session.go index 4c72d31b..f8add80d 100644 --- a/session.go +++ b/session.go @@ -1711,6 +1711,9 @@ func (session *Session) bytes2Value(col *Column, fieldValue *reflect.Value, data return errors.New("arg " + key + " as int: " + err.Error()) } if x != 0 { + // !nashtsai! TODO for hasOne relationship, it's preferred to use join query for eager fetch + // however, also need to consider adding a 'lazy' attribute to xorm tag which allow hasOne + // property to be fetched lazily structInter := reflect.New(fieldValue.Type()) newsession := session.Engine.NewSession() defer newsession.Close()