Fix BUG: Update statement build function should ingore ONLYFROMDB fields (#1012)

* Fix BUG: Update statement build function should ingore ONLYFROMDB fields

* Add test case

* Modify test case
This commit is contained in:
DrWrong(Yuhang) 2018-06-23 14:59:01 +08:00 committed by Lunny Xiao
parent 1de9d224b6
commit f16ce722ec
2 changed files with 38 additions and 0 deletions

View File

@ -261,6 +261,10 @@ func (statement *Statement) buildUpdates(bean interface{},
continue continue
} }
if col.MapType == core.ONLYFROMDB {
continue
}
fieldValuePtr, err := col.ValueOf(bean) fieldValuePtr, err := col.ValueOf(bean)
if err != nil { if err != nil {
engine.logger.Error(err) engine.logger.Error(err)

View File

@ -203,3 +203,37 @@ func TestDistinctAndCols(t *testing.T) {
assert.EqualValues(t, 1, len(names)) assert.EqualValues(t, 1, len(names))
assert.EqualValues(t, "test", names[0]) assert.EqualValues(t, "test", names[0])
} }
func TestUpdateIgnoreOnlyFromDBFields(t *testing.T) {
type TestOnlyFromDBField struct {
Id int64 `xorm:"PK"`
OnlyFromDBField string `xorm:"<-"`
OnlyToDBField string `xorm:"->"`
IngoreField string `xorm:"-"`
}
assertGetRecord := func() *TestOnlyFromDBField {
var record TestOnlyFromDBField
has, err := testEngine.Where("id = ?", 1).Get(&record)
assert.NoError(t, err)
assert.EqualValues(t, true, has)
assert.EqualValues(t, "", record.OnlyFromDBField)
return &record
}
assert.NoError(t, prepareEngine())
assertSync(t, new(TestOnlyFromDBField))
_, err := testEngine.Insert(&TestOnlyFromDBField{
Id: 1,
OnlyFromDBField: "a",
OnlyToDBField: "b",
IngoreField: "c",
})
assert.NoError(t, err)
record := assertGetRecord()
record.OnlyFromDBField = "test"
testEngine.Update(record)
assertGetRecord()
}