From f76246da0af031d4b2e6ce9db74fac9d3f456ebd Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Mon, 21 Apr 2014 17:49:34 +0800 Subject: [PATCH] small improvement --- oracle_dialect.go | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/oracle_dialect.go b/oracle_dialect.go index 36a2f62d..b22db57a 100644 --- a/oracle_dialect.go +++ b/oracle_dialect.go @@ -223,19 +223,6 @@ func (db *oracle) GetIndexes(tableName string) (map[string]*core.Index, error) { return indexes, nil } -// PgSeqFilter filter SQL replace ?, ? ... to :1, :2 ... -type OracleSeqFilter struct { -} - -func (s *OracleSeqFilter) Do(sql string, dialect core.Dialect, table *core.Table) string { - counts := strings.Count(sql, "?") - for i := 1; i <= counts; i++ { - newstr := ":" + fmt.Sprintf("%v", i) - sql = strings.Replace(sql, "?", newstr, 1) - } - return sql -} - func (db *oracle) Filters() []core.Filter { - return []core.Filter{&core.QuoteFilter{}, &OracleSeqFilter{}, &core.IdFilter{}} + return []core.Filter{&core.QuoteFilter{}, &core.SeqFilter{":", 1}, &core.IdFilter{}} }