This should solve #1954 and adds some tests for it. I will note I'm not 100% clear on whether there are other edge cases that should be covered here. From what I understand the only standard SQL way to escape single quotes is to double them, which shouldn't cause any problems with this, but if some SQL flavors allow other kinds of escaping, for instance, that would probably need to be covered too for ideal results.
Co-authored-by: Hlín Önnudóttir <hlin@nanitor.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1955
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: antialiasis <antialiasis@noreply.gitea.io>
Co-committed-by: antialiasis <antialiasis@noreply.gitea.io>
names with upper charactor on postgres will need quotes
Fix bug
Add new quote parameter on tests
Fix bug
Fix tests
Fix quotes
fix test
Improve quote policy
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1567
Fix test
Fix test
Add new Quoter object to handle quote
Fix join table name quote bug
Move reserve words related files into dialects sub package (#1544)
Move reserve words related files into dialects sub package
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1544
Fix mssql quote (#1535)
Fix some quotes
Fix mssql quote
Merge core package back into the main repository and split into serval sub packages. (#1543)
Fix test
Improve fmt
update go.mod
Move core as a sub package
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1543
Fix int time deleted bug (#1539)
Fix panic
Fix test
Fix test for mssql time
Add sql type check on deleted cond
Fix int time deleted bug
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1539
Add test for mysql8.0 (#1538)
Fix pk order on test
Add test for mysql8.0
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1538
Add test for join limit (#1536)
Add test for join limit
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1536
Improve drone (#1537)
Fix drone
Improve drone
* use traditional positional parameters on inser...
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1537
Fix slice of struct not cache bug (#895)
Fix failure caused by nil bean
Judge both type of struct and pointer in case of out-of-range
Fix issue #894
Add test for join subquery (#1528)
Fix test
Fix subquery with schema
Add test for join subquery
Add makefile (#1531)
Fix drone
Fix ci
Add deps
Improve drone
Fix envs
Add makefile
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1531
Add password for postgres drone image (#1530)
Add password for postgres drone image
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1530
format time when sqlTypeName is core.Varchar (#1026)
fix time test
add test for time format
sign codes according to contributing rules.
format time when sqlTypeName is core.Varchar. Same with core.DateTime or core.TimeStamp
Add test for second insert error (#1527)
Add test for second insert error
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1527
Add tests for table name (#1517)
add tests for table name
Fix test (#1526)
Fix test
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1526
Fix test (#1526)
Fix test
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1526
Fix wrong warning log on autoincrement column when sync table (#1525)
improve doc
Fix wrong warning log on autoincrement column when sync table
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1525
Fixed Join strings on func Exist (#1520)
fix test
fixed Join strings on func Exist
Co-authored-by: Tomofumi Kusana <tkusana@morisawa.co.jp>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1520
For nullable columns, store nil values as NULL (#531)
Merge branch 'master' into jcsalem/fix/nil_ptr_is_nullable
fix bug when buffersize with iterate (#941)
Merge branch 'master' into lunny/fix_buffer_iterate
Exclude schema from index name (#1505)
Merge branch 'master' into fix-schema-idx
SetExpr support more go types (#1499)
Improve tests
SetExpr support more go types
fix vet
fix drone lint
remove go1.10 test on drone
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1499
fix vet
fix drone lint
remove go1.10 test on drone
Exclude schema from the index name
Co-authored-by: Guillermo Prandi <guillep2k@users.noreply.github.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1505
fix test
fix bug
fix bug when buffersize with iterate
SetExpr support more go types (#1499)
Improve tests
SetExpr support more go types
fix vet
fix drone lint
remove go1.10 test on drone
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1499
fix vet
fix drone lint
remove go1.10 test on drone
Fix update with Alias (#1455)
Co-authored-by: Guillermo Prandi <guillep2k@noreply.gitea.io>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/941
fix update map with version (#1448)
fix test
fix update map with version
SetExpr support more go types (#1499)
Improve tests
SetExpr support more go types
fix vet
fix drone lint
remove go1.10 test on drone
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1499
fix vet
fix drone lint
remove go1.10 test on drone
Fix update with Alias (#1455)
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1448
Exclude schema from index name (#1505)
Merge branch 'master' into fix-schema-idx
SetExpr support more go types (#1499)
Improve tests
SetExpr support more go types
fix vet
fix drone lint
remove go1.10 test on drone
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1499
fix vet
fix drone lint
remove go1.10 test on drone
Exclude schema from the index name
Co-authored-by: Guillermo Prandi <guillep2k@users.noreply.github.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1505
SetExpr support more go types (#1499)
Improve tests
SetExpr support more go types
fix vet
fix drone lint
remove go1.10 test on drone
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1499
For nullable columns, store nil values as NULL
fix vet
fix drone lint
remove go1.10 test on drone
Fix update with Alias (#1455)
Improve c...
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1534
Lunny Xiao
antialiasis