when using distinct cols with FindAndCount, reset statement.ColumnMap will make the counting sql an syntax error, this pr try fix this.
is this pr ok for merge?
error sql logging:
```sql
[SQL] SELECT DISTINCT `Fid` FROM `table_demo` WHERE Fkey = ? [val]
[SQL] SELECT count(DISTINCT ) FROM `table_demo` WHERE Fkey = ? [val]
```
after fix:
```sql
[SQL] SELECT DISTINCT `Fid` FROM `table_demo` WHERE Fkey = ? [val]
[SQL] SELECT count(DISTINCT `Fid`) FROM `table_demo` WHERE Fkey = ? [val]
```
Co-authored-by: finelog <kaicltw@gmail.com>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/2096
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: finelog <finelog@noreply.gitea.io>
Co-committed-by: finelog <finelog@noreply.gitea.io>
Since `conversion.Conversion` has been referenced by external package, it should not be moved as internal package.
Reviewed-on: https://gitea.com/xorm/xorm/pulls/2030
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-committed-by: Lunny Xiao <xiaolunwen@gmail.com>
Remove depreciated functions and move some functions to schemas
Move zero functions to a standalone package
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1548
Fix panic
Fix test
Fix test for mssql time
Add sql type check on deleted cond
Fix int time deleted bug
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1539
Fix failure caused by nil bean
Judge both type of struct and pointer in case of out-of-range
Fix issue #894
Add test for join subquery (#1528)
Fix test
Fix subquery with schema
Add test for join subquery
Add makefile (#1531)
Fix drone
Fix ci
Add deps
Improve drone
Fix envs
Add makefile
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1531
Add password for postgres drone image (#1530)
Add password for postgres drone image
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1530
format time when sqlTypeName is core.Varchar (#1026)
fix time test
add test for time format
sign codes according to contributing rules.
format time when sqlTypeName is core.Varchar. Same with core.DateTime or core.TimeStamp
Add test for second insert error (#1527)
Add test for second insert error
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1527
Add tests for table name (#1517)
add tests for table name
Fix test (#1526)
Fix test
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1526
Fix test (#1526)
Fix test
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1526
Fix wrong warning log on autoincrement column when sync table (#1525)
improve doc
Fix wrong warning log on autoincrement column when sync table
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1525
Fixed Join strings on func Exist (#1520)
fix test
fixed Join strings on func Exist
Co-authored-by: Tomofumi Kusana <tkusana@morisawa.co.jp>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1520
For nullable columns, store nil values as NULL (#531)
Merge branch 'master' into jcsalem/fix/nil_ptr_is_nullable
fix bug when buffersize with iterate (#941)
Merge branch 'master' into lunny/fix_buffer_iterate
Exclude schema from index name (#1505)
Merge branch 'master' into fix-schema-idx
SetExpr support more go types (#1499)
Improve tests
SetExpr support more go types
fix vet
fix drone lint
remove go1.10 test on drone
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1499
fix vet
fix drone lint
remove go1.10 test on drone
Exclude schema from the index name
Co-authored-by: Guillermo Prandi <guillep2k@users.noreply.github.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1505
fix test
fix bug
fix bug when buffersize with iterate
SetExpr support more go types (#1499)
Improve tests
SetExpr support more go types
fix vet
fix drone lint
remove go1.10 test on drone
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1499
fix vet
fix drone lint
remove go1.10 test on drone
Fix update with Alias (#1455)
Co-authored-by: Guillermo Prandi <guillep2k@noreply.gitea.io>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/941
fix update map with version (#1448)
fix test
fix update map with version
SetExpr support more go types (#1499)
Improve tests
SetExpr support more go types
fix vet
fix drone lint
remove go1.10 test on drone
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1499
fix vet
fix drone lint
remove go1.10 test on drone
Fix update with Alias (#1455)
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1448
Exclude schema from index name (#1505)
Merge branch 'master' into fix-schema-idx
SetExpr support more go types (#1499)
Improve tests
SetExpr support more go types
fix vet
fix drone lint
remove go1.10 test on drone
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1499
fix vet
fix drone lint
remove go1.10 test on drone
Exclude schema from the index name
Co-authored-by: Guillermo Prandi <guillep2k@users.noreply.github.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1505
SetExpr support more go types (#1499)
Improve tests
SetExpr support more go types
fix vet
fix drone lint
remove go1.10 test on drone
Reviewed-on: https://gitea.com/xorm/xorm/pulls/1499
For nullable columns, store nil values as NULL
fix vet
fix drone lint
remove go1.10 test on drone
Fix update with Alias (#1455)
Improve ci tests (#1477)
Rewrite Engine.QuoteTo() to accept multi-part identifiers (#1476)
Support local sql log (#1338)
Fix go mod and update version (#1460)
Move github.com/go-xorm/xorm to xorm.io/xorm (#1459)
add support custom type Nullfloat64 (#1450)
fix bug when query map condtion with no quote (#1449)
Don't warn when bool column default is 1 but not true (#1447)
* don't warn when bool column default is 1 but not true
* fix default case sensitive
Fix sync2 with custom table name (#1445)
* fix sync2 with custom table name
* fix bug on postgres
* fix bug on postgres
fix bug when update with setexpr (#1446)
add tidb tests on drone ci (#1444)
improve sync2 (#1443)
Fix wrong dbmetas (#1442)
* add tests for db metas
* add more tests
* fix bug on mssql
Fix default value parse bugs (#1437)
* fix default value
* fix default value tags
* fix postgres default
* fix default on postgres
* fix default on postgres
* fix mssql default
fix arg conversion (#1441)
* fix arg conversion
* fix bugs
* fix bug on postgres
* use traditional positional parameters on insert into select
* remove unnecessary tests
upgrade core (#1440)
add tests (#1439)
...
Co-authored-by: shanyy <shanyy163@163.com>
Co-authored-by: kusana <kusana@noreply.gitea.io>
Co-authored-by: Guillermo Prandi <guillep2k@noreply.gitea.io>
Co-authored-by: Guillermo Prandi <guillep2k@noreply@gitea.io>
Co-authored-by: yudppp <yu.d.ppp@gmail.com>
Reviewed-on: https://gitea.com/xorm/xorm/pulls/895
Diego Sogari
Lunny Xiao
finelog
Slory7